scott/blockinator
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Changed the SQLite3 error handling due to possible SegFault and invalid pointer messages in Apache.

Browse source
This commit is contained in:
Scott Wallace 2012-11-20 14:53:18 +00:00
parent ce22093fd4
commit af891a04d3
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
apache/mod_blockinator.c
View file

@ -57,7 +57,6 @@ static int mod_blockinator_method_handler(request_rec *r)
{ {
const char *remote_ip, *forwarded_ip, *useragent; const char *remote_ip, *forwarded_ip, *useragent;
char *statement; char *statement;
char *sqlite3_error;
sqlite3_stmt *sqlite3_statement; sqlite3_stmt *sqlite3_statement;
int sqlite3_rc; int sqlite3_rc;
@ -94,10 +93,10 @@ static int mod_blockinator_method_handler(request_rec *r)
/* Tidy-up the SQLite way. */ /* Tidy-up the SQLite way. */
if (sqlite3_finalize(sqlite3_statement) != SQLITE_OK) { if (sqlite3_finalize(sqlite3_statement) != SQLITE_OK) {
ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r, "SQLite error freeing the SQLite compile statement (%s). Possible memory leak.", sqlite3_error); ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r, "SQLite error freeing the SQLite compile statement (%s). Possible memory leak.", sqlite3_errmsg(db));
sqlite3_free(sqlite3_error);
} }
sqlite3_free(statement);
return DECLINED; return DECLINED;
} }
@ -106,8 +105,6 @@ static int mod_blockinator_method_handler(request_rec *r)
*/ */
static void mod_blockinator_init_handler(apr_pool_t *p, server_rec *s) static void mod_blockinator_init_handler(apr_pool_t *p, server_rec *s)
{ {
char *sqlite3_error;
/* Read config from module */ /* Read config from module */
blockinator_cfg_t *cfg = ap_get_module_config(s->module_config, &blockinator_module); blockinator_cfg_t *cfg = ap_get_module_config(s->module_config, &blockinator_module);